UK Vintage Radio Repair and Restoration Powered By Google Custom Search Vintage Radio Service Data

Go Back   UK Vintage Radio Repair and Restoration Discussion Forum > Other Discussions > Forum Announcements and Comments

Notices

Forum Announcements and Comments Announcements about forum changes will be made in this section.

Closed Thread
 
Thread Tools
Old 24th Nov 2016, 7:28 pm   #1
Paul Stenning
Administrator
 
Paul Stenning's Avatar
 
Join Date: Dec 2002
Location: Cardiff
Posts: 7,278
Default Image rotation when uploading

I have just made a change to the image upload code to read the EXIF orientation data from images and rotate them accordingly before resizing them.

This should mean no more photos appearing with the wrong rotation when uploaded as attachments or in albums etc.

If you have had this problem before please upload the offending images again (if you have them) in this thread as a test. Obviously it needs to be the original ones from your phone or camera, not edited ones.

It would be interesting to see how well or otherwise this works, as the amount of testing I could do is limited.
__________________

Paul Stenning
Forum Admin/Owner and BVWS Committee Member
Paul Stenning is offline  
Old 24th Nov 2016, 7:40 pm   #2
thermionic
Heptode
 
thermionic's Avatar
 
Join Date: Apr 2003
Location: Cornwall, UK.
Posts: 648
Default Re: Image rotation when uploading

Hi Paul.

I'll upload a couple of images of the 'Genalex' electric clock that I posted in November 2014 that rotated during upload.

Let's see what happens.




Well, that worked fine!
Attached Thumbnails
Click image for larger version

Name:	IMG_0306.jpg
Views:	89
Size:	47.2 KB
ID:	133331   Click image for larger version

Name:	IMG_0307.jpg
Views:	72
Size:	74.6 KB
ID:	133332  
__________________
The honesty of imperfection..........

Last edited by thermionic; 24th Nov 2016 at 7:41 pm. Reason: Comment on successful outcome!
thermionic is online now  
Old 25th Nov 2016, 12:42 am   #3
Paul Stenning
Administrator
 
Paul Stenning's Avatar
 
Join Date: Dec 2002
Location: Cardiff
Posts: 7,278
Default Re: Image rotation when uploading

It seems to have added black to the right side so may need more tweaking. I will have a further look in the next couple of days to sort that.
__________________

Paul Stenning
Forum Admin/Owner and BVWS Committee Member
Paul Stenning is offline  
Old 25th Nov 2016, 9:38 am   #4
Paul Stenning
Administrator
 
Paul Stenning's Avatar
 
Join Date: Dec 2002
Location: Cardiff
Posts: 7,278
Default Re: Image rotation when uploading

Thank you to Simon (thermionic) for emailing me the offending images. I think it is now sorted.

Note that it will only correct the rotation of images if they are large enough to require resizing anyway, however as images from almost any smartphone or digital camera will be over that limit so this shouldn't be an issue.

Let's see how it works over the next few days.
Attached Thumbnails
Click image for larger version

Name:	IMG_0306.jpg
Views:	39
Size:	37.8 KB
ID:	133360   Click image for larger version

Name:	IMG_0307.jpg
Views:	40
Size:	53.9 KB
ID:	133361  
__________________

Paul Stenning
Forum Admin/Owner and BVWS Committee Member
Paul Stenning is offline  
Old 25th Nov 2016, 5:36 pm   #5
Nymrod121
Octode
 
Nymrod121's Avatar
 
Join Date: Apr 2012
Location: Worcestershire, UK.
Posts: 1,588
Default Re: Image rotation when uploading

Okay, let's try this one (previously uploaded to the FSoW thread 15/11/16) ....
Attached Thumbnails
Click image for larger version

Name:	20161115_132411.jpg
Views:	65
Size:	42.2 KB
ID:	133379  
__________________
"Halt! - who goes there?"
'Baa-aa-aah ..." ('The Dish': 2000)
Nymrod121 is offline  
Old 25th Nov 2016, 5:37 pm   #6
Nymrod121
Octode
 
Nymrod121's Avatar
 
Join Date: Apr 2012
Location: Worcestershire, UK.
Posts: 1,588
Default Re: Image rotation when uploading

Yep - worked just fine.
Nice one, Paul ... thank you!
__________________
"Halt! - who goes there?"
'Baa-aa-aah ..." ('The Dish': 2000)
Nymrod121 is offline  
Old 25th Nov 2016, 7:21 pm   #7
merlinmaxwell
Dekatron
 
merlinmaxwell's Avatar
 
Join Date: Jul 2008
Location: Maidenhead, Berkshire, UK.
Posts: 8,381
Default Re: Image rotation when uploading

One thing I would like is a bit more resolution for images, so often a printed page posted is unreadable, it is usually possible to de cypher it, but that's no fun.
__________________
Cats have staff, it's dogs that have owners.
merlinmaxwell is online now  
Old 25th Nov 2016, 9:19 pm   #8
Paul Stenning
Administrator
 
Paul Stenning's Avatar
 
Join Date: Dec 2002
Location: Cardiff
Posts: 7,278
Default Re: Image rotation when uploading

For things like diagrams and documents it is best to store them full size image in a ZIP file, or create a PDF file. There is a higher maximum file size limit and no automatic resizing.

I don't want to increase the maximum size for images due to the amount of disk space having almost every image attachment larger would take up.
__________________

Paul Stenning
Forum Admin/Owner and BVWS Committee Member
Paul Stenning is offline  
Old 25th Nov 2016, 9:48 pm   #9
Nuvistor
Dekatron
 
Nuvistor's Avatar
 
Join Date: Aug 2013
Location: Wigan, Greater Manchester, UK.
Posts: 6,863
Default Re: Image rotation when uploading

Not Radio related but try as a test.
Frank
That works ok, delete this post if you wish, just wanted to test.
Attached Thumbnails
Click image for larger version

Name:	IMG_2014.jpg
Views:	87
Size:	52.0 KB
ID:	133398  

Last edited by Nuvistor; 25th Nov 2016 at 9:50 pm. Reason: Delete if required.
Nuvistor is online now  
Old 25th Nov 2016, 9:54 pm   #10
Dave Moll
Dekatron
 
Dave Moll's Avatar
 
Join Date: Feb 2005
Location: West Cumbria (CA13), UK
Posts: 4,105
Default Re: Image rotation when uploading

It may not be related to vintage tech, but does shift the balance a little from the usual feline fare.
__________________
Mending is better than Ending (cf Brave New World by Aldous Huxley)
Dave Moll is offline  
Old 26th Nov 2016, 12:28 pm   #11
Herald1360
Dekatron
 
Herald1360's Avatar
 
Join Date: Feb 2007
Location: Leominster, Herefordshire, UK.
Posts: 13,219
Default Re: Image rotation when uploading

__________________
....__________
....|____||__|__\_____
.=.| _---\__|__|_---_|.
.........O..Chris....O
Herald1360 is offline  
Old 26th Nov 2016, 9:33 pm   #12
Paul Stenning
Administrator
 
Paul Stenning's Avatar
 
Join Date: Dec 2002
Location: Cardiff
Posts: 7,278
Default Re: Image rotation when uploading

I'll leave this thread open for a few more days, but just for people to report any problems with this change now please.

If you do have problems I will probably PM you and ask you to email me the offending image(s) to test with.
__________________

Paul Stenning
Forum Admin/Owner and BVWS Committee Member
Paul Stenning is offline  
Closed Thread

Thread Tools



All times are GMT +1. The time now is 7:48 am.


All information and advice on this forum is subject to the WARNING AND DISCLAIMER located at https://www.vintage-radio.net/rules.html.
Failure to heed this warning may result in death or serious injury to yourself and/or others.


Powered by vBulletin®
Copyright ©2000 - 2019, vBulletin Solutions, Inc.
Copyright ©2002 - 2019, Paul Stenning.